[react devtools][easy] Change function names and remove unused functions, add constants, etc #25211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbalicki2
changed the title
* Change variable names, put stuff in constants, etc. in preparation for next diff
lunaruan
reviewed
Sep 8, 2022
| ); | ||
| return parseBool(raw) ?? true; |
There was a problem hiding this comment.
we probably don't need the parseBool method (might create unnecessary indirection that might make the code more confusing) What do you think about removing parseBool and replacing it with something like:
return typeof raw === 'string' && raw === 'false' ? false : true;
lunaruan
approved these changes
Sep 8, 2022
| return true; | ||
| } | ||
|
|
||
| export function setShowInlineWarningsAndErrors(value: boolean): void { |
There was a problem hiding this comment.
If you remove this you can probably also remove the other setters since they're also not used
There was a problem hiding this comment.
I think I removed all the unused setters 👍
There was a problem hiding this comment.
Only one of the setters was used, and it was used in setupTests (but didn't actually affect the output of any tests)
sammy-SC
pushed a commit
that referenced
this pull request
Sep 11, 2022
* Change variable names, put stuff in constants, etc. in preparation for next diff
rickhanlonii
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Change variable names, put stuff in constants, etc. in preparation for next diff
rickhanlonii
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Change variable names, put stuff in constants, etc. in preparation for next diff
GrinZero
added a commit
to GrinZero/react
that referenced
this pull request
Nov 7, 2022
* 'main' of ssh://github.com/GrinZero/react: (51 commits) Flow: add simple explicit export types to Devtools (facebook#25251) [react devtools][easy] Centralize calls to patchConsoleUsingWindowValues (facebook#25222) Unwind the current workInProgress if it's suspended (facebook#25247) Add early exit to strict mode (facebook#25235) fix: prettier ignore removed and fixed (facebook#24811) Flow: enable unsafe-addition error (facebook#25242) Flow: upgrade to 0.132 (facebook#25244) Flow: fix Fiber typed as any (facebook#25241) Flow: ReactFiberHotReloading recursive type (facebook#25225) Add some test coverage for some error cases (facebook#25240) experimental_use(context) for server components and ssr (facebook#25226) Flow: upgrade to 0.131 (facebook#25224) Prevent infinite re-renders in StrictMode + Offscreen (facebook#25203) Flow: remove explicit object syntax (facebook#25223) Flow: upgrade to 0.127 (facebook#25221) Flow: enable exact_by_default (facebook#25220) [react devtools] Don't check for NODE_ENV==='test' because it never is (facebook#25186) [react devtools][easy] Change variable names, etc. (facebook#25211) Bump async from 2.6.3 to 2.6.4 in /fixtures/concurrent/time-slicing (facebook#24443) Flow: implicit-inexact-object=error (facebook#25210) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
setShowInlineWarningsAndErrors, which is only called insetupTestsand is unnecessary.getXXX: boolean()functions, which will no longer returnJSON.parse(...). Instead, we check for the stringstrueandfalse.How did you test this change?
yarn prettier,yarn run test-build-devtools,yarn run flow dom